Knapsack: Fix empty list of items #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senekor
force-pushed
the
knapsack-fix-canonical-data
branch
from
6d8caac
to
8706b8c
Compare
IsaacG
reviewed
Dec 9, 2023
| @@ -12,6 +12,17 @@ | |||
| }, | |||
| "expected": 0 | |||
| }, | |||
| { | |||
| "uuid": "3993a824-c20e-493d-b3c9-ee8a7753ee59", | |||
| "reimplements": "a4d7d2f0-ad8a-460c-86f3-88ba709d41a7", | |||
There was a problem hiding this comment.
Do we need a re-implements when the expected generated test code shouldn't change?
There was a problem hiding this comment.
Well, the CI tests fail if I change the existing test case 🤷
There was a problem hiding this comment.
It's technically a breaking change, so yeah the reimplements makes sense here I think.
IsaacG
approved these changes
Dec 9, 2023
wolf99
approved these changes
Dec 9, 2023
ErikSchierboom
approved these changes
Dec 12, 2023
| @@ -12,6 +12,17 @@ | |||
| }, | |||
| "expected": 0 | |||
| }, | |||
| { | |||
| "uuid": "3993a824-c20e-493d-b3c9-ee8a7753ee59", | |||
| "reimplements": "a4d7d2f0-ad8a-460c-86f3-88ba709d41a7", | |||
There was a problem hiding this comment.
It's technically a breaking change, so yeah the reimplements makes sense here I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.